Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

New publisher: Some validation plugin tweaks #4339

Merged
merged 9 commits into from
Jan 19, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 18, 2023

Brief description

A small collection of minor tweaks to plugins to improve usage in new publisher.

Description

  • Fix typo (missing space) in houdini plug-in

  • Change "Validate Containers" label to "Validate Outdated Containers" so the Options appear more understandable.

afbeelding

  • Refactor error for Validate Versions to KnownPublishError for nicer error report. Changes here are also focused on keeping it readable in the old publisher since it's a global plug-in.

afbeelding

Testing notes:

  1. Test the validations! :)

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jan 18, 2023

I noticed by the way that "Validate Version" doesn't appear to work for Pointcache instances in Houdini. The pointcache instances appear to have no "latestVersion" data collected. It's None in the validate versions validator.

Seems like a bug?

@mkolar
Copy link
Member

mkolar commented Jan 19, 2023

I noticed by the way that "Validate Version" doesn't appear to work for Pointcache instances in Houdini. The pointcache instances appear to have no "latestVersion" data collected. It's None in the validate versions validator.

Seems like a bug?

Sounds like it to me.

@mkolar mkolar added the type: bug Something isn't working label Jan 19, 2023
@mkolar mkolar merged commit e0b0b51 into ynput:develop Jan 19, 2023
@github-actions github-actions bot added this to the next-patch milestone Jan 19, 2023
@jakubjezek001 jakubjezek001 modified the milestones: next-patch, 3.15.0 Jan 25, 2023
@BigRoy BigRoy deleted the new_publisher_plugin_tweaks branch March 20, 2024 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants