Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Unreal: Don't use mongo queries in 'ExistingLayoutLoader' #4356

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Unreal: Don't use mongo queries in 'ExistingLayoutLoader' #4356

merged 5 commits into from
Jan 19, 2023

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Unreal load plugin ExistingLayoutLoader used direct mongo calls using legacy_io.find_one and imported from openpype.api. Both should not be used anymore.

Description

Use get_representations function to get representations instead of direct queries. Replaced querying of representations one by one into 2 chunks. Added class attribute delete_unmatched_assets which stores value of "delete_unmatched_assets" from unreal settings (overriden classmethod apply_settings) -> removed import from openpype.api.

Testing notes:

  1. Loader should work as did before this PR (maybe faster)

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 19, 2023
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Jan 19, 2023
@iLLiCiTiT @simonebarbieri
Fix adding to set
028c476 
Co-authored-by: Simone Barbieri <simone.barbieri@hey.com>
@iLLiCiTiT iLLiCiTiT merged commit 0e08d3d into develop Jan 19, 2023
@iLLiCiTiT iLLiCiTiT deleted the feature/not_use_mongo_query_unreal_loader branch January 19, 2023 18:15
@github-actions github-actions bot added this to the next-patch milestone Jan 19, 2023
@jakubjezek001 jakubjezek001 modified the milestones: next-patch, 3.15.0 Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonebarbieri simonebarbieri simonebarbieri approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @simonebarbieri @jakubjezek001