Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya template builder load all assets linked to the shot #4761

Conversation

ClementHector
Copy link
Contributor

Problem
All the assets of the ftrack project are loaded and not those linked to the shot

How get error
Open maya in the context of shot, then build a new scene with the "Build Workfile from template" button in "OpenPype" menu.
image

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Maya labels Mar 31, 2023
@BigRoy
Copy link
Collaborator

BigRoy commented Apr 3, 2023

Code looks fine to me. I haven't used the template builder yet so will push this on to review by someone at Ynput team.

@LiborBatek
Copy link
Member

@ClementHector could you provide info how your Template file look? Also exact testing steps to perform for review.

Maybe also @iLLiCiTiT can shed some light on Template files and your issue (after providing additional info).

After that I will try it out and test it. Thanks!

@iLLiCiTiT
Copy link
Member

Maybe also @iLLiCiTiT can shed some light on Template files and your issue (after providing additional info).

I have no idea how it works in maya. I just took #3315 and made it host agnostic & plugin based.

@ClementHector
Copy link
Contributor Author

@ClementHector could you provide info how your Template file look?

@LiborBatek As said @iLLiCiTiT you can look at the method of the issue #3315 , it has not changed :)

LiborBatek
LiborBatek previously approved these changes Apr 4, 2023
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested and working ok. I have created Template file for Lighting task, Build the scene from Template file and checked all related assets got in correctly in.

Only corresponding asset got loaded. So all seems normal and working

image

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Apr 5, 2023

Wow, what happened? The PR is somewhat broken and GH think there are changes from other closed PRs. Did you rebase it?

@ClementHector
Copy link
Contributor Author

I used the rebase for the first time from the interface, it will be the last time XD
I will correct that!

@ClementHector ClementHector force-pushed the 363-fix-studio-openpype-does-not-load-assets-linked-to-the-shot branch from 70ae46a to 46438c0 Compare April 5, 2023 13:38
@ClementHector ClementHector force-pushed the 363-fix-studio-openpype-does-not-load-assets-linked-to-the-shot branch from 46438c0 to 9be576c Compare April 5, 2023 13:40
@ClementHector
Copy link
Contributor Author

Ok it's better and up to date.

Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iLLiCiTiT iLLiCiTiT assigned antirotor and unassigned iLLiCiTiT and LiborBatek Apr 11, 2023
@tokejepsen
Copy link
Member

@LiborBatek you happy with this?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works ok. So approved.

@mkolar mkolar merged commit d1b59c4 into ynput:develop Apr 13, 2023
@ynbot ynbot added this to the next-patch milestone Apr 13, 2023
@ClementHector ClementHector deleted the 363-fix-studio-openpype-does-not-load-assets-linked-to-the-shot branch April 14, 2023 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community contribution host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants