Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

add label to matching family #5128

Conversation

ClementHector
Copy link
Contributor

Changelog Description

I added the possibility to filter the family smart select with the label in addition to the family.

Additional info

The family smart select does not work with the default settings and it is not intuitive for users to have to know the family instead of the family label.

Testing notes:

With the default settings (to test this new add):

  1. open a light task in maya
  2. open the creator interface
  3. if it works Render is selected

To test the legacy code change the family smart select option from render to rendering:

  1. open a light task in maya
  2. open the creator interface
  3. if it works Render is selected

@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label Jun 12, 2023
@ClementHector ClementHector marked this pull request as ready for review June 12, 2023 09:40
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why not to use the family. But the creator tool is used only in Maya and Blender, and will probably be removed when they are converted to publisher, I'm not against.

@iLLiCiTiT iLLiCiTiT merged commit 59b7e26 into ynput:develop Jun 15, 2023
@ynbot ynbot added this to the next-patch milestone Jun 15, 2023
ClementHector added a commit to quadproduction/OpenPype that referenced this pull request Jun 16, 2023
* add label to matching family

* Update openpype/tools/creator/model.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@ClementHector ClementHector deleted the 451-families-smart-select-use-family-instead-label branch June 16, 2023 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants