Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

#241 - Implementation of pype-config/presets/plugins/standalonepublisher #517

Merged

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Sep 16, 2020

Implemented schema for pype-config/presets/plugins/standalonepublisher
241_standalonepublisher

Requires:
pypeclub/pype/#479

@mkolar
Copy link
Member

mkolar commented Sep 16, 2020

Can you try wrapping the individual items in a dict-form? they will get nicely aligned. Ready to merge after. Also please change target directly to develop

@kalisp
Copy link
Member Author

kalisp commented Sep 16, 2020

According to @iLLiCiTiT 'ExtractReviewSP' shouldn't be there at all. Removed from implementation.
Needs to be removed from 'pype-config' in separate PR.

@kalisp kalisp changed the base branch from feature/241-config_gui to develop September 16, 2020 14:45
@kalisp kalisp requested a review from mkolar September 16, 2020 14:45
@mkolar mkolar merged commit 3fa1037 into ynput:develop Sep 16, 2020
@kalisp kalisp deleted the feature/241-config_gui-standalonepublisher branch September 16, 2020 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants