Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

#241 - Implemented pype-config/presets/plugins/nukestudio/filter.json #521

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Sep 16, 2020

Added filter.json implementation for GUI settings

Not sure if there isn't better option as these check-boxes seem of two disjunctive sets (either strict OR benevolent). But current .json allowed nonsensical variants too.

241_nukestudio

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Sep 16, 2020

I'm aftraid "filter" keys in publishing are raw-jsons as both keys and keys in the value are modifiable.

@mkolar
Copy link
Member

mkolar commented Sep 16, 2020

This should be probably rewritten to only have those two plugin checkboxes. Strict vs Benevolent should be just about how they are set up. It was really done this way due to current architecture. But eventually with setting presets it won't be needed.

@mkolar
Copy link
Member

mkolar commented Sep 16, 2020

Actually it does make sense. It is for filter in publish GUI. soooo I'd at least rename the category to Publish GUI Filters

@kalisp
Copy link
Member Author

kalisp commented Sep 16, 2020

So it should be kept this way, only rename 'Filter' to 'Publish GUI Filters' ?
Are those actually used in code anywhere? I couln't find them anywhere.

@iLLiCiTiT
Copy link
Member

So it should be kept this way, only rename 'Filter' to 'Publish GUI Filters' ?

Definetelly raw-json. Whole value of "filter" key is fully customizable.

Are those actually used in code anywhere? I couln't find them anywhere.

~/pype/tools/pyblish_pype/control.py around line 123

Both keys and values for this field are editable, no valid widget for such a case
@kalisp
Copy link
Member Author

kalisp commented Sep 17, 2020

Reverted back to raw-json, at least renamed.
241_nukestudio_2

@mkolar mkolar merged commit 3741c8f into ynput:develop Sep 17, 2020
@kalisp kalisp deleted the feature/241-config_gui_nukestudio branch September 17, 2020 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants