Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Standalone publisher editorial plugins interfering #580

Merged
merged 9 commits into from
Oct 1, 2020

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Sep 30, 2020

  • editorial plugins were interfering with other families

  • adding "clip" family to better filter editorial instances

  • render/plates workflow fixes including:

    • space in input path was crashing standalone publisher
    • space in input path was crashing burning ocio script
    • when input resolution was not dividable by two it was crashing ffmpeg (solution was to add pad filter to add half frame pad to both sides)

closes #579

@jakubjezek001 jakubjezek001 added this to the 2.12 milestone Sep 30, 2020
@jakubjezek001 jakubjezek001 requested a review from a team September 30, 2020 10:47
@jakubjezek001 jakubjezek001 self-assigned this Sep 30, 2020
@jakubjezek001 jakubjezek001 linked an issue Sep 30, 2020 that may be closed by this pull request
@jakubjezek001
Copy link
Member Author

@mkolar it is check on client project and working well now

@jakubjezek001
Copy link
Member Author

@mkolar i was commiting from client machine with your user on it.. sry

@@ -453,6 +453,7 @@ def ffmpeg_full_args(
if audio_filters:
all_args.append("-filter:a {}".format(",".join(audio_filters)))

all_args.append('-vf pad="width=ceil(iw/2)*2:height=ceil(ih/2)*2"')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break what is happening in def rescaling_filters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea how to fix it the way it will not break those filters?

@mkolar mkolar merged commit 9cd15b9 into master Oct 1, 2020
@mkolar mkolar modified the milestones: 2.12, 2.12.3 Oct 1, 2020
@mkolar mkolar deleted the hotfix/579-Publish_EDL branch October 6, 2020 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish EDL
3 participants