-
Notifications
You must be signed in to change notification settings - Fork 129
Enhancement: Workfile Templates add events, plugin discovery, run script and build from published workfile #5830
Enhancement: Workfile Templates add events, plugin discovery, run script and build from published workfile #5830
Conversation
- Cleanup code by re-using more library functions - Register plug-in as plug-in path for dynamic reloads - Allow storing more complex data, e.g. `EnumDef` with `multiselection=True` - Reorder into outliner to next to placeholder locator
…yet - if all required arguments are passed along
@ClementHector could this be of interest to you for some test runs? But maybe @mre7a and @friquette have a say as well. |
…/github.com/BigRoy/OpenPype into enhancement/workfile_templates_enhancements
@@ -90,7 +94,9 @@ def install(self): | |||
register_loader_plugin_path(LOAD_PATH) | |||
register_creator_plugin_path(CREATE_PATH) | |||
register_inventory_action_path(INVENTORY_PATH) | |||
self.log.info(PUBLISH_PATH) | |||
|
|||
# TODO: Expose this via a dedicated `register_template_plugin_path` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this TODO and I think it should be separated PR, merged before this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you like to name the dedicated function for it?
register_workfile_template_builder_placeholder_plugin_path
Seems a bit too verbose haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iLLiCiTiT any naming preference on this? I can take a look at creating a separate PR for this then.
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
…/github.com/BigRoy/OpenPype into enhancement/workfile_templates_enhancements
Could we resolve the merge conflicts before any testing? I would also suggest maybe splitting this into smaller PRs. |
…file_templates_enhancements # Conflicts: # openpype/lib/events.py
…on the Placeholders.
@tokejepsen Resolved the conflicts - should be testable again. Some features have become available in develop already which already takes quite a bit of complexity out of this PR. And I've updated the PR description for that as well - and marked one todo there that would be nice to implement outside of this PR which then makes the diff of this PR smaller in scope as well. I've refactored usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of cool stuff here for the workfile builder!
I think there is a lot to test on this PR, so could you update the testing notes with different cases we should look for?
For example I see the plugins look assigner and run python script.
Added testing notes to PR description - is this sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is bugfix in this PR as well.
I've got two subsets of family model
. In current develop
it'll only bring in 1 model subset main
, but testing this PR and it brings in both; main
and unique
subsets.
Could very well be - there's also some fixes in how it orders things in the outliner, etc. I just 'patched' as I hit issues while testing and implementing whilst keeping in mind in the code 'original behavior' but just fixing Maya code issues that I knew could have edge cases where it failed. So it's hoping I didn't actually break another thing! ;) |
Could we update the description, just so we are clear on release what might happen for studios updating. I think it's correct behaviour but studios might be used to a single subset being loaded. Unless the original intent was 1 subset per placeholder? |
As far as I know the placeholder design of Workfile Templates was always designed to behave like that. |
Because we're splitting OpenPype into ayon-core and individual host addons, this PR would have to be re-created to target one of those. We're closing it down, but we'll he happy for a new PR to ynput/ayon-core or the host addon repository once it's up. |
Changelog Description
Additional info
Events
Allow partial functions registered with the Event Systemalready implemented in developAdd OrderedEventSystemalready implemented in developPlug-in discovery
Other
Maya
EnumDef
withmultiselection=True
Reorder
help utilities to maya lib, since it made code easier for the Load Placeholder for maya.Also see this comment here describing what might be other todos to investigate or discuss.
Testing notes:
order
attribute)