This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Renaming nukestudio host folder to hiero #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjezek001
added
type: enhancement
|
we have a few small issues with the rename We just need to add |
mkolar
suggested changes
Oct 6, 2020
There was a problem hiding this comment.
Also while doing it we need to make sure that collect_hierarchy_context.py runs after collection resolution. they have the same order now and randomly switch places, breaking publishing.
second thing that should be updated with this is changing task creation to dictionary instead of a list to comply with the latest changes in #572
|
all fixed and tested, ready to merge @mkolar |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming host namespace from nukestudio to hiero
dependence:
ynput/pype-config#86
Closes #616