Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Publisher window as dialog #6176

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 26, 2024

Changelog Description

Changing back Publisher window to QDialog.

Additional info

The reasoning for changing it to QWidget was to avoid having window always on top, which QDialog might cause on it's own (even without AlwaysOnTop flag). But it was found out that using QWidget with Window flag did break window positioning for some DCCs and broke stylesheets for almost all of them, especially when parent was passed to init. The reason why that happens was not revealed.

At the same time there was random behavior in substance painter where the publisher tool was moved under substance without any user interaction, when parent was not passed in, and had broken stylesheets when parent was passed in.

This might again raise issues when a DCC opens dialog that is modal, it might show under publisher and block the process.

Testing notes:

  1. Publisher should show ok in all DCCs
  • Blender
  • Maya
  • Max
  • SPainter
  • Photoshop
  • Nuke
  • Resolve
  • Houdini
  • Fusion
  • Flame
  • Harmony
  • Celaction
  • After Effects
  • UE

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working labels Jan 26, 2024
@LiborBatek
Copy link
Member

Performed test in SP the Publisher window seems behaving ok in terms of focus and not being always on top but there is still that weird enlarging issue of the window present... not sure if related to this PR or if it should be ignored atm.

the UI progressively grows to the right of the screen infinitely
image

@tokejepsen
Copy link
Member

Publisher should show ok in all DCCs

Might be worth having a checklist of DCCs to tick off as we test them.

@LiborBatek
Copy link
Member

When testing Photoshop, Im facing issue with context being lost...again not fully sure if connected to this PR

Screenshot 2024-01-29 102327

After trying to Save Im getting this error msg

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5\openpype\pipeline\create\context.py", line 2359, in _save_instance_changes
    creator.update_instances(update_list)
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5\openpype\hosts\photoshop\lib.py", line 32, in update_instances
    api.stub().imprint(created_inst.get("instance_id"),
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5\openpype\hosts\photoshop\api\launch_logic.py", line 102, in stub
    raise ConnectionNotEstablishedYet("Connection is not created yet")
openpype.hosts.photoshop.api.launch_logic.ConnectionNotEstablishedYet: Connection is not created yet

@LiborBatek
Copy link
Member

@iLLiCiTiT
Copy link
Member Author

the UI progressively grows to the right of the screen infinitely

Unrelated to this PR.

After trying to Save Im getting this error msg

Unrelated to PR, @kalisp please contact @LiborBatek and take a look.

@LiborBatek
Copy link
Member

@MustafaJafar maybe could u help with testing too (Houdini and maybe more) ?

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Houdini. It worked fine for me.

@iLLiCiTiT iLLiCiTiT merged commit 9affc2c into develop Feb 7, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/publisher-window-as-dialog branch February 7, 2024 10:11
@ynbot ynbot added this to the next-patch milestone Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants