Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Publisher: Show message with error on action failure #6179

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions openpype/tools/publisher/control.py
Original file line number Diff line number Diff line change
Expand Up @@ -2329,8 +2329,25 @@ def run_action(self, plugin_id, action_id):
result = pyblish.plugin.process(
plugin, self._publish_context, None, action.id
)
exception = result.get("error")
if exception:
self._emit_event(
"publish.action.failed",
{
"title": "Action failed",
"message": "Action failed.",
"traceback": "".join(
traceback.format_exception(exception)
),
"label": action.__name__,
"identifier": action.id
}
)

self._publish_report.add_action_result(action, result)

self.emit_card_message("Action finished.")

def _publish_next_process(self):
# Validations of progress before using iterator
# - same conditions may be inside iterator but they may be used
Expand Down
15 changes: 15 additions & 0 deletions openpype/tools/publisher/window.py
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,9 @@ def __init__(self, parent=None, controller=None, reset_on_show=None):
controller.event_system.add_callback(
"convertors.find.failed", self._on_convertor_error
)
controller.event_system.add_callback(
"publish.action.failed", self._on_action_error
)
controller.event_system.add_callback(
"export_report.request", self._export_report
)
Expand Down Expand Up @@ -1012,6 +1015,18 @@ def _on_convertor_error(self, event):
event["title"], new_failed_info, "Convertor:"
)

def _on_action_error(self, event):
self.add_error_message_dialog(
event["title"],
[{
"message": event["message"],
"traceback": event["traceback"],
"label": event["label"],
"identifier": event["identifier"]
}],
"Action:"
)

def _update_create_overlay_size(self):
metrics = self._create_overlay_button.fontMetrics()
height = int(metrics.height())
Expand Down
Loading