Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Validate write node fix error report - OP-8088 #6183

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

tokejepsen
Copy link
Member

Changelog Description

Report error was not printing the expected values from settings, but instead the values on the write node, leading to confusing messages like:

Traceback (most recent call last):
  File "C:\Users\tokejepsen\AppData\Local\Ynput\AYON\dependency_packages\ayon_2310271602_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\tokejepsen\OpenPype\openpype\hosts\nuke\plugins\publish\validate_write_nodes.py", line 135, in process
    self._make_error(check)
  File "C:\Users\tokejepsen\OpenPype\openpype\hosts\nuke\plugins\publish\validate_write_nodes.py", line 149, in _make_error
    raise PublishXmlValidationError(
openpype.pipeline.publish.publish_plugins.PublishXmlValidationError: Write node's knobs values are not correct!
Knob 'channels' > Correct: `rgb` > Wrong: `rgb`

This PR changes the error report to:

Traceback (most recent call last):
  File "C:\Users\tokejepsen\AppData\Local\Ynput\AYON\dependency_packages\ayon_2310271602_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\tokejepsen\OpenPype\openpype\hosts\nuke\plugins\publish\validate_write_nodes.py", line 135, in process
    self._make_error(check)
  File "C:\Users\tokejepsen\OpenPype\openpype\hosts\nuke\plugins\publish\validate_write_nodes.py", line 149, in _make_error
    raise PublishXmlValidationError(
openpype.pipeline.publish.publish_plugins.PublishXmlValidationError: Write node's knobs values are not correct!
Knob 'channels' > Expected: `['rg']` > Current: `rgb`

Testing notes:

  1. Setup wrong value in ayon+settings://nuke/imageio/nodes/required_nodes/0/knobs?project=demo_Commercial
  2. Publish in Nuke and verify the report mentions the settings values.

@ynbot ynbot added host: Nuke type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Feb 1, 2024
@tokejepsen tokejepsen changed the title Nuke: Validate write node fix error report Nuke: Validate write node fix error report - OP-8088 Feb 1, 2024
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubjezek001 jakubjezek001 merged commit 5c52626 into develop Feb 9, 2024
1 check passed
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-8088_validate-write-node-report branch February 9, 2024 15:02
@ynbot ynbot added this to the next-patch milestone Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON target: OpenPype type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants