This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
sync to avalon doesn t remove renamed task #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part for manual syncing through Action
Part for syncing through Event server
Rewrite of approach, simplified, in any task change is noticed, parents of changed tasks are captured, all task entities are pulled from Ftrack and Task dictionaries are recreated from scratch.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| passed_regex = avalon_sync.check_regex( | ||
| entity["name"], "task", | ||
| schema_patterns=self.regex_schemas | ||
| ) |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
| tasks_per_ftrack_id[ftrack_id] = {} | ||
|
|
||
| passed_regex = avalon_sync.check_regex( | ||
| entity["name"], "task", |
There was a problem hiding this comment.
continuation line over-indented for hanging indent
mkolar
approved these changes
Oct 8, 2020
mkolar
changed the title
kalisp
deleted the
bugfix/605-sync-to-avalon-doesn-t-remove-renamed-task
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #605
Reworked task handling in Event server. Simplified, any change in task will force collection of task information for Asset from FTrack and recreation of Task dictionary in Avalon Asset.