This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
[QUAD] Bug: Fix attribute_definitions.py typos #6346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -951,7 +953,7 @@ def deserialize_attr_def(attr_def_data): | |||
| """Deserialize attribute definition from data. | |||
|
|
|||
| Args: | |||
| attr_def (Dict[str, Any]): Attribute definition data to deserialize. | |||
| attr_def_data (Dict[str, Any]): Attribute definition data to deserialize. | |||
BigRoy
reviewed
Sep 11, 2024
| @@ -760,7 +762,7 @@ def from_dict(cls, data): | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_paths(cls, paths, allow_sequences): | |||
| def from_paths(cls, paths, allow_sequences=False): | |||
There was a problem hiding this comment.
Any reason for this change?
BigRoy
added a commit
to BigRoy/ayon-core
that referenced
this pull request
Sep 11, 2024
|
Ported to here - except for the one comment about the added default argument value. @iLLiCiTiT should we port this? Closing this one since there's an equivalent PR there. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.