Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

611 Simplify Hiero tag workflow #648

Closed

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Oct 16, 2020

  • refactoring Tag workflow - removing json, adding pype tag for single taging
  • adding functions to lib for plugin wide use
  • Creator with gui and renamer for hierarchical data use
  • Publishing plugins refactoring for single tag collection
  • Collectors in publishing refactoring for pre-collecting faze of publisher
  • Loading clip to timeline with update and remove, containerized and activated Manage menu item

What to test in Shot Creator plugin ui?

  • Renaming with Hiero tool and only generating tag in one layer > select clips in single layer which are renamed with hiero's build in renaming tool (select clips / Editorial / Rename) and check if the P. Tag was created with correct asset. It should be the same as the original name of clip after rename > Rename clips False
  • Renaming with tool and layer names defining subset names with vertical synchronization > create clips in multiple layers. Rename layers to subset name. Slips should be exactly above each other. Select all clips in layers. In UI panel set > Vertical rename True, Master track (Usually main), Subset name <track_name>
  • Renaming with tool and no vertical synchronization used (if all clips across layers are individual assets) > Vertical rename False, Subset name main

@jakubjezek001 jakubjezek001 added type: enhancement Enhancements to existing functionality MEDIUM host: Hiero labels Oct 16, 2020
@jakubjezek001 jakubjezek001 added this to the 2.14 milestone Oct 16, 2020
@jakubjezek001 jakubjezek001 requested a review from a team October 16, 2020 11:47
@jakubjezek001 jakubjezek001 self-assigned this Oct 16, 2020
@jakubjezek001 jakubjezek001 force-pushed the feature/611-simplify-hiero-tag-workflow branch from ce49ac5 to 6d44ee0 Compare November 23, 2020 10:57
@mkolar mkolar force-pushed the 2.x/develop branch 2 times, most recently from 46534d7 to 461dc0e Compare December 8, 2020 16:58
reset_selection
)

from .lib import (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'.lib.get_sequence_pattern_and_padding' imported but unused
'.lib.is_overlapping' imported but unused

@mkolar mkolar added duplicate This issue or pull request already exists and removed 2x-dev type: enhancement Enhancements to existing functionality host: Hiero labels Jan 22, 2021
@mkolar
Copy link
Member

mkolar commented Jan 22, 2021

this pr was cleaned up and replicated in #907 so we can close this

@mkolar mkolar closed this Jan 22, 2021
@mkolar mkolar deleted the feature/611-simplify-hiero-tag-workflow branch January 26, 2021 08:49
mkolar added a commit that referenced this pull request Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Hiero tag workflow
2 participants