Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

TVPaint extract review fix #740

Merged
merged 3 commits into from
Nov 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pype/plugins/global/publish/extract_review.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,24 @@ def main_process(self, instance):

# Loop through representations
for repre in tuple(instance.data["representations"]):
repre_name = str(repre.get("name"))
tags = repre.get("tags") or []
if "review" not in tags or "thumbnail" in tags:
if "review" not in tags:
self.log.debug((
"Repre: {} - Didn't found \"review\" in tags. Skipping"
).format(repre_name))
continue

if "thumbnail" in tags:
self.log.debug((
"Repre: {} - Found \"thumbnail\" in tags. Skipping"
).format(repre_name))
continue

if "passing" in tags:
self.log.debug((
"Repre: {} - Found \"passing\" in tags. Skipping"
).format(repre_name))
continue

input_ext = repre["ext"]
Expand Down
3 changes: 3 additions & 0 deletions pype/plugins/tvpaint/publish/collect_instances.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def process(self, context):
)
)

if instance is None:
continue

frame_start = context.data["frameStart"]
frame_end = frame_start
for layer in instance.data["layers"]:
Expand Down
3 changes: 1 addition & 2 deletions pype/plugins/tvpaint/publish/extract_sequence.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ def process(self, instance):
# Fill tags and new families
tags = []
if family_lowered in ("review", "renderlayer"):
# Add `ftrackreview` tag
tags.append("ftrackreview")
tags.append("review")

repre_files = [
os.path.basename(filepath)
Expand Down