Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Extract review audio cut fix #763

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 1, 2020

Issue

  • ExtractReview cut audio if input is sequence because will set frames:v ...

Changes

  • argument frames:v ... for output is used only if output is sequence
  • audio inputs have set duration with help of -to argument where duration in seconds is filled
  • same is applied for input if input is image sequence and output is not image sequence
    • this is to specify how many frames should be used from input
  • shortest argument was removed (as all inputs have defined duration)

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 1, 2020
@iLLiCiTiT iLLiCiTiT requested a review from a team December 1, 2020 13:12
@mkolar mkolar changed the base branch from master to release/2.14.2 December 1, 2020 22:20
@mkolar mkolar added the type: bug Something isn't working label Dec 1, 2020
@mkolar mkolar added this to the 2.14.2 milestone Dec 1, 2020
@mkolar mkolar merged commit a47042a into release/2.14.2 Dec 2, 2020
@mkolar mkolar deleted the hotfix/extract_review_audio_cut_fix branch December 4, 2020 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants