Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

escape executables in pre launch hooks #940

Merged
merged 5 commits into from
Jan 29, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jan 29, 2021

Safer escaping of path in pre launch hooks. Without this some paths on Windows might be troublesome in Pype3.

@kalisp kalisp self-assigned this Jan 29, 2021
@mkolar mkolar added the type: bug Something isn't working label Jan 29, 2021
@mkolar mkolar added this to the 3.0 milestone Jan 29, 2021
@mkolar mkolar requested a review from iLLiCiTiT January 29, 2021 10:39
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. It won't work in pype build but it works for development. Until #924 is resolved.

@mkolar mkolar merged commit 1d940f8 into develop Jan 29, 2021
@kalisp kalisp deleted the 3.0/bugfix/escape_executables_in_pre_launch_hooks branch February 4, 2021 17:36
@nextreleaseio nextreleaseio bot mentioned this pull request Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants