Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Feature/loader with aggregation loading state #158

Merged
merged 8 commits into from
Jul 17, 2020

Conversation

iLLiCiTiT
Copy link
Member

Adapted changed from upstream PR getavalon#555.

Changes

  • last versions in loader are queried with aggreate function which is much faster
  • documents are queried in thread so loader is not blocked, meanwhile loading animation is showed
  • colums in subset view has predefined widths

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 26, 2020
asset_docs_by_id is None
or subset_docs_by_id is None
or last_versions_by_subset_id is None
or len(self._asset_ids) == 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break before binary operator

if (
asset_docs_by_id is None
or subset_docs_by_id is None
or last_versions_by_subset_id is None
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break before binary operator

)
if (
asset_docs_by_id is None
or subset_docs_by_id is None
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break before binary operator

@iLLiCiTiT iLLiCiTiT requested a review from a team June 26, 2020 08:47
@mkolar mkolar merged commit b3452ed into 2.x/develop Jul 17, 2020
@mkolar mkolar deleted the feature/loader_with_aggregation_loading_state branch October 18, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants