Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Ruff pycodestyle warnings #7

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Added pycodestyle warnings to ruff selection.

Additional info

Warnings contain complains about trailing spaces, new line characters etc.

Testing notes:

  1. Validate the changes.

Copy link

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I know nothing of the validation error numbers, etc. But this does look like it'd select more and hence be stricter - so I'll give it a thumbs up.

But if you have any good pointers on how to accurately confirm it does what we want, let me know.

@iLLiCiTiT
Copy link
Member Author

But if you have any good pointers on how to accurately confirm it does what we want, let me know.

It looks like actions can't run in template repositories. I did run it manually (create venv, activate venv, install ruff, run ruff check in root of repository).

@iLLiCiTiT iLLiCiTiT merged commit b4eee1a into develop Sep 3, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/stricter-ruff branch September 3, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants