Deadline: webservice password

[kalisp]

Changelog Description

This PR provides support for Deadline Webservice authentication.

Additional info

Settings are rudimentary and will need to be changed as we currently don't have password type of SettingsField which would mask and hash values. AFAIK I cannot use Secrets as they are not per artist.

Currently each artist needs to provide credentials via Site Settings, I didn't provide some default values as I assume if client expects authentication they will not use shared account.

This PR actually affects all existing DL integrations as they might need to have authentication injected.

• After Effects
• Blender
• Maya
• 3ds Max
• Fusion
• Nuke
• Houdini

Testing notes:

1. Enable authentication in Deadline Monitor Tools>Configure Repository Options>Web Service Settings>Require Authentication
2. Build and deploy new deadline addon
3. Enable authentication requirement for DL server in ayon+settings://deadline
   
4. Create user in DL and provide password (in Webservice password)
   
5. Use these credentials in Site Settings
   

[kalisp]

I can't even get to the point 5. Deadline addon is not displayed at Site sync tab:-

Please make sure that you have deadline addon set in Production bundle, Site Settings are on applicable for addons in there. They will be used even if you use Dev bundle, but they must be in Production one too (which is a bit confusing).

[64qam]

When I set a authentication in DL, Deadline web service validator fails:

DEBUG: http://127.0.0.1:8081 "GET / HTTP/1.1" 401 0
Traceback (most recent call last):
  File "C:\Users\qam\AppData\Local\Ynput\AYON\dependency_packages\ayon_2403071252_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\qam\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.1\ayon_core\modules\deadline\plugins\publish\validate_deadline_connection.py", line 32, in process
    assert response.ok, "Response must be ok"
AssertionError: Response must be ok

[LiborBatek]

Im getting error when trying to submit Render to DL from the Blender host app

INFO: Using C:\projects\Ayon_Tests\blender\b3d_shots\sh020\publish\workfile\workfileLighting\v003\ATS_sh020_workfileLighting_v003.blend for render/export.
Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Work\REPO\ayon-core\client\ayon_core\modules\deadline\abstract_submit_deadline.py", line 468, in process
    auth = instance.data["deadline"]["auth"]
           ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
KeyError: 'auth'

[LiborBatek]

Speaking of Fusion all working well and without any issues... tested on Fusion 18

[LiborBatek]

Sucessfully tested also in Nuke host app. All fine and no errors experienced.

[LiborBatek]

@MustafaJafar could you test in Houdini host pls? thx

[MustafaJafar]

I found some bugs with cache publishing.

These two lines:

ayon-core/client/ayon_core/modules/deadline/plugins/publish/submit_publish_cache_job.py

Lines 358 to 359 in 25c9481

	for inst in instances:
	inst["deadlineUrl"] = self.deadline_url

should be

        # Inject deadline url to instances to query DL for job id for overrides
        for inst in instances:
            if "deadline" not in inst:
                inst["deadline"] = {}
            inst["deadline"] = instance.data["deadline"]

[MustafaJafar]

It works on my side.
Tested publishing render, caches. Also, checked the files after publishing they are as expected.

[64qam]

In AE it fails during DL web service validation:

  File "C:\Users\qam\AppData\Local\Ynput\AYON\dependency_packages\ayon_2403071252_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\qam\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.1\ayon_core\modules\deadline\plugins\publish\validate_deadline_connection.py", line 24, in process
    deadline_url = instance.data["deadline"]["url"]
TypeError: 'NoneType' object is not subscriptable

When Nuke job is already on farm, there is DL error:

Error
=======================================================
Error: Global job preload script 'C:\ProgramData\Thinkbox\Deadline10\workers\qamtop\plugins\66354fbf50445baecead81e2\GlobalJobPreLoad.py': Missing required env vars: AVALON_PROJECT, AVALON_ASSET, AVALON_TASK, AVALON_APP_NAME (FranticX.Scripting.PythonNetException)
  File "C:\ProgramData\Thinkbox\Deadline10\workers\qamtop\plugins\66354fbf50445baecead81e2\GlobalJobPreLoad.py", line 487, in inject_ayon_environment
    raise RuntimeError((
  File "C:\ProgramData\Thinkbox\Deadline10\workers\qamtop\plugins\66354fbf50445baecead81e2\GlobalJobPreLoad.py", line 624, in __main__
    inject_ayon_environment(deadlinePlugin)
   at Python.Runtime.PythonException.ThrowLastAsClrException() in C:\thinkbox-conda\conda-bld\dotnet_pythonnet_1688438502375\work\src\runtime\PythonException.cs:line 53
   at Python.Runtime.PyObject.Invoke(PyObject[] args) in C:\thinkbox-conda\conda-bld\dotnet_pythonnet_1688438502375\work\src\runtime\PythonTypes\PyObject.cs:line 750
   at Python.Runtime.PyObject.InvokeMethod(String name, PyObject[] args) in C:\thinkbox-conda\conda-bld\dotnet_pythonnet_1688438502375\work\src\runtime\PythonTypes\PyObject.cs:line 818
   at FranticX.Scripting.PythonNetScriptEngine.CallFunction(String moduleName, String functionName, Object[] args)
   at Deadline.Plugins.PluginWrapper.d()
   at Deadline.Plugins.PluginWrapper.StartJob(String& outMessage, AbortLevel& abortLevel)

=======================================================
Type
=======================================================
RenderPluginException

=======================================================
Stack Trace
=======================================================
   at Deadline.Plugins.SandboxedPlugin.d(DeadlineMessage bgq, CancellationToken bgr)
   at Deadline.Plugins.SandboxedPlugin.StartJob(Job job, CancellationToken cancellationToken)
   at Deadline.Slaves.SlaveRenderThread.c(TaskLogWriter ajv, CancellationToken ajw)```

My job's envs are:
![Screenshot 2024-05-03 232858](https://github.com/ynput/ayon-core/assets/26925793/21bd55d1-abd4-486e-8b72-0283f0849691)

[kalisp]

Fixed AE (issue in order).

I think that issue with GlobalJobPreLoad is that you have older version, not ayon-core.0.3.0 one.
Code should like this:

Fixed