Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuke: simplified deadline submission on write node - AY-974 #314
Nuke: simplified deadline submission on write node - AY-974 #314
Changes from 24 commits
c6d72a6
eca60b0
8514005
cd45e9a
4f70d30
756e1f9
4fcab3c
b6a5ead
acacf15
0462d38
157ff08
81c7584
a3c2bb1
e5fbb20
ce13e86
8a971f3
978e7d1
e9dc1d4
72116cd
5b591b6
54500db
fd71818
d8eb451
ad7d24c
c752e35
818aaf9
8c4a79c
8f4334f
a75cb56
459e9a5
3debb92
4c6eb7a
23ee1ca
3dfe367
8eb5c2a
da4da46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too bad this is in
nuke.api.utils
- this is really something that should be "easy" to retrieve from the publishing API and should not need a 'nuke specific implementation' I would say.Anyway, docstring would be welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be at least renamed to
create_publish_error_report
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it very confusing that throughout the code you keep mentioning "publish". This workflow is not doing any publish right? It's only doing a Nuke render in the farm?