Maya: abc options for Pointcache/Animation family - AY-970 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…cache-Animation-family # Conflicts: # openpype/hosts/maya/api/plugin.py # openpype/hosts/maya/plugins/create/create_animation.py # openpype/hosts/maya/plugins/create/create_pointcache.py # openpype/hosts/maya/plugins/publish/extract_pointcache.py
…cache-Animation-family # Conflicts: # openpype/hosts/maya/plugins/create/create_animation.py # openpype/settings/defaults/project_settings/maya.json
…cache-Animation-family
…cache-Animation-family
…cache-Animation-family # Conflicts: # openpype/hosts/maya/plugins/create/create_animation.py
iLLiCiTiT
reviewed
Apr 15, 2024
client/ayon_core/hosts/maya/plugins/publish/validate_alembic_options_defaults.py
Outdated
Show resolved
Hide resolved
BigRoy
reviewed
Apr 15, 2024
client/ayon_core/hosts/maya/plugins/create/create_animation_pointcache.py
Outdated
Show resolved
Hide resolved
client/ayon_core/hosts/maya/plugins/publish/collect_animation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…intcache.py Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
…ptions_defaults.py Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…ache-Animation-family # Conflicts: # server_addon/maya/server/version.py
…n-family' of github.com:ynput/ayon-core into enhancement/AY-970_abc-options-for-Pointcache-Animation-family
mkolar
deleted the
enhancement/OP-5920_abc-options-for-Pointcache-Animation-family
branch
|
Massive work everyone! :) |
|
Getting this error after this PR: |
|
Next error after that is: DEBUG: Extracting pointcache..
Traceback (most recent call last):
File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\dependency_packages\ayon_2404022047_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
runner(*args)
File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.3\ayon_core\hosts\maya\plugins\publish\extract_pointcache.py", line 165, in process
"writeCreases", self.writeCreases
AttributeError: 'ExtractAnimation' object has no attribute 'writeCreases' |
|
Next error is: Traceback (most recent call last):
File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2403071252_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
runner(*args)
File "E:\dev\ayon-core\client\ayon_core\hosts\maya\plugins\publish\extract_pointcache.py", line 218, in process
extract_alembic(**kwargs)
TypeError: extract_alembic() got an unexpected keyword argument 'userAttr'I get the feeling this PR was merged too quickly? :D |
BigRoy
reviewed
May 1, 2024
| "renderableOnly": False, | ||
| "stripNamespaces": True, | ||
| "uvsOnly": False, | ||
| "uvWrite": False, |
There was a problem hiding this comment.
Do we really feel this is a sensible studio default we should offer from AYON by default. With this False by default Alembics will be written without UVs - pretty sure we'll want to flip that. Right @tokejepsen @mkolar ?
BigRoy
reviewed
May 1, 2024
| "bake_attributes": [], | ||
| "bake_attribute_prefixes": [], | ||
| "dataFormat": "ogawa", | ||
| "eulerFilter": False, |
There was a problem hiding this comment.
This defaulted to True before, by making this False with this PR this now means there is a difference in default behavior.
BigRoy
reviewed
May 1, 2024
| "writeFaceSets": False, | ||
| "writeNormals": True, | ||
| "writeUVSets": False, | ||
| "writeVisibility": False |
There was a problem hiding this comment.
This defaulted to True before this PR - with this now False any animated visibilities (or even any visilities whatsoever) will not be published along. Do we feel that's a sensible default value for AYON?
BigRoy
reviewed
May 1, 2024
| frameRange="", | ||
| noNormals=False, | ||
| preRoll=False, | ||
| preRollStartFrame=0, |
There was a problem hiding this comment.
Pretty sure this functionality does not work?
I'm seeing this in my extraction logs:
# Warning: Ignoring unsupported flag: -preRollStartFrame
# Warning: Ignoring unsupported flag: 0
There was a problem hiding this comment.
It seems preRollStartFrame is not a job argument but a direct argument to AbcExport. See logic here. So the current implementation here is broken. @tokejepsen that will have to be rewritten a different way then.
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Port of ynput/OpenPype#5173