Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applications: update inline docs for only_available in applications addon settings #471

Merged
merged 9 commits into from
May 29, 2024
Merged

Applications: update inline docs for only_available in applications addon settings #471

merged 9 commits into from
May 29, 2024

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Apr 30, 2024 •
edited
Loading

Changelog Description

Add some inline docs for only_available setting in application addon.

Additional info

This PR was made based on some community feedback.

Testing notes:

  1. Everything should remain the same..
  2. Tell me if the added inline docs make sense.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels Apr 30, 2024
BigRoy
BigRoy reviewed Apr 30, 2024
View reviewed changes
server_addon/applications/server/settings.py Outdated Show resolved Hide resolved
server_addon/applications/server/settings.py Outdated Show resolved Hide resolved
server_addon/applications/server/settings.py Outdated Show resolved Hide resolved
server_addon/applications/server/settings.py Outdated Show resolved Hide resolved
MustafaJafar and others added 3 commits April 30, 2024 16:24
@MustafaJafar @BigRoy
Update the description of only_available
639d837 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@MustafaJafar @BigRoy
Remove shortcut from docstring
914448a 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@MustafaJafar
applications: update ApplicationsSettings
5149802
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label May 3, 2024
@MustafaJafar MustafaJafar marked this pull request as draft May 3, 2024 11:34
@MustafaJafar MustafaJafar changed the title Applications: update inline docs for applications and only_available Applications: update inline docs for only_available in applications addons May 23, 2024
@MustafaJafar MustafaJafar changed the title Applications: update inline docs for only_available in applications addons Applications: update inline docs for only_available in applications addon settings May 23, 2024
@MustafaJafar MustafaJafar marked this pull request as ready for review May 23, 2024 09:30
@MilaKudr MilaKudr self-requested a review May 29, 2024 07:50
@MustafaJafar MustafaJafar merged commit 8366d2e into develop May 29, 2024
1 check passed
@MustafaJafar MustafaJafar deleted the enhancement/applications-update-inline-docs branch May 29, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy left review comments

@MilaKudr MilaKudr MilaKudr approved these changes

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees
No one assigned
Labels
community Issues and PRs coming from the community members size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MustafaJafar @BigRoy @MilaKudr @ynbot