Settings: Host imageio use AYON settings #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
type: enhancement
iLLiCiTiT
requested review from
kalisp,
antirotor,
jakubjezek001 and
moonyuet
moonyuet
reviewed
Feb 14, 2024
There was a problem hiding this comment.
It doesn't work at Max when enabled imageio and global ocio config(not sure if it is related to this particular PR). The script editor shows me an error when I use the Set Colorspace in Max
Maybe it is somehow related to the ocio env hook isn't installed correctly in Max.
My core settings in imageio:
My Max settings in imageio:
Have a look if you are having activated |
jakubjezek001
approved these changes
Feb 14, 2024
moonyuet
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Imageio settings in hosts does not require conversion.
Additional info
The changes should be affecting only settings that are used in
colorspace.py. Modifiedcolorspace.pyto use AYON data structure. I'm not sure if there is a host which is using directly imageio settings that are handled bycolorspace.py? I couldn't find any.Testing notes:
I need help with testing notes as I don't know what it in fact affects. Probably validate if imageio is used correctly during publishing?