Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workfiles tool: Author visible in UI #552

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 24, 2024

Changelog Description

Add author username to workfiles tool.

Additional info

Workfiles tool shows author of workfile based on workfile info on server or author of published version.

It was discovered that workfile info does not fill createdBy and updatedBy automatically, which is fixed in AYON server 1.1.3, but for backwards compatibility they're both filled and auto-fixed when updating existing file.

The UI shows create user instead of update user, maybe that is not right? Also the UI is "not enough" wide to show all the information, maybe we should make the tool wider by default? Not sure if my workfile template is "production standard" but it does not fit.

Screenshot

image

Testing notes:

  1. Launch a host of your choice.
  2. Save workfile via workfiles tool.
  3. Open workfile tool again.
  4. The new workfile should have author filled with your username.
  5. Published workfiles should show author of the representation.

@ynbot
Copy link
Contributor

ynbot commented May 24, 2024

@ynbot ynbot added type: feature Adding something new and exciting to the product size/S labels May 24, 2024
@m-u-r-p-h-y
Copy link
Member

m-u-r-p-h-y commented May 26, 2024

The UI shows create user instead of update user, maybe that is not right? Also the UI is "not enough" wide to show all the information, maybe we should make the tool wider by default? Not sure if my workfile template is "production standard" but it does not fit.

It is a good question. I would rather see the last user who touched the file instead of the original author. Would you agree @dee-ynput ?

or should we have two columns there? (author and edited by)?

@64qam 64qam requested a review from MilaKudr May 27, 2024 12:26
@BigRoy
Copy link
Collaborator

BigRoy commented May 28, 2024

It is a good question. I would rather see the last user who touched the file instead of the original author. Would you agree @dee-ynput ?

Agreed - last modified author makes most sense as data to me - especially because it also lists date modified, not date created.
By the way, can we make it display the user's nice name?

The UI shows create user instead of update user, maybe that is not right? Also the UI is "not enough" wide to show all the information, maybe we should make the tool wider by default? Not sure if my workfile template is "production standard" but it does not fit.

Agree that having it fit by default would be nice.

Side note: can we get author also on the "Details:" right hand side?

@MilaKudr MilaKudr self-requested a review May 30, 2024 08:22
Copy link

@MilaKudr MilaKudr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-30 102140

@iLLiCiTiT iLLiCiTiT merged commit a1bf47b into develop May 30, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the feature/AY-5569_Workfile-tool-Artist-name-visibility branch May 30, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants