Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create logic: Fix parent property in PublishAttributeValues #558

Merged
merged 1 commit into from
May 28, 2024
Merged

Create logic: Fix parent property in PublishAttributeValues #558

merged 1 commit into from
May 28, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Property parent actually does return the parent object.

Testing notes:

  1. The property is not used so there is not much to test.

@ynbot ynbot added size/XS type: bug Something isn't working labels May 28, 2024
BigRoy
BigRoy approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but the change itself makes sense.

@iLLiCiTiT iLLiCiTiT merged commit 11932a2 into develop May 28, 2024
9 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/return-parent-in-parent-property branch May 28, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@antirotor antirotor Awaiting requested review from antirotor

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@kalisp kalisp

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iLLiCiTiT @BigRoy @kalisp @ynbot