Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene manager: Show statuses #564

Merged
merged 15 commits into from
May 30, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Added statuses to scene inventory manager.

Additional info

The code of scene inventory tool was not much clear so it was "easier" to refactor some parts for easier understanding where and how data are comming in. The refactor is done only in bounds of this feature. Also discovered few bugs that probably caused issues even in current develop, if you hit a bug please make sure it is bug related to this PR.

Screenshot

image
image

Testing notes:

  1. Launch host of your choice.
  2. Load/reference some representations in.
  3. Scene inventory should show them.
  4. You should be able to change their version, update and remove them, switch to hero and back, switch to different representation.
  5. Status should show current status of version of loaded representation.

@ynbot
Copy link
Contributor

ynbot commented May 29, 2024

Task linked: AY-5611 Add statuses to scene manager

@ynbot ynbot added size/XXL type: enhancement Improvement of existing functionality or minor addition labels May 29, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have started testing it in Maya host app and have some first issues:

  1. Update All isnt working atm
Screenshot 2024-05-30 085014
  1. Filter outdated isnt working atm

  2. Hero version doesnt propagate status from the origin for ie v003 and [v003] doesnt match status

Screenshot 2024-05-30 085113

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@iLLiCiTiT
Copy link
Member Author

  1. Update All isnt working atm

Fixed

  1. Filter outdated isnt working atm

Fixed

  1. Hero version doesnt propagate status from the origin for ie v003 and [v003] doesnt match status

Hero version has own status, it is not related to origin version.

@iLLiCiTiT iLLiCiTiT requested a review from LiborBatek May 30, 2024 08:13
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now even Filter outdated and Update all outdated works ok.

I have also did some additional testing within Blender host app and all good too!

@LiborBatek
Copy link
Member

If something to note, there is a slight UX issue with Qt formating or so...

Could be aligned to Version column imho all the time
ScnInv

@iLLiCiTiT iLLiCiTiT merged commit 4bddd64 into develop May 30, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/AY-5611_Add-statuses-to-scene-manager branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL type: enhancement Improvement of existing functionality or minor addition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants