Expand folders when searching in the folder widgets (Loader + Launcher). #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
type: enhancement
|
Let me know what you think about the code @iLLiCiTiT - pointers are welcome to restructure or move this logic elsewhere. |
iLLiCiTiT
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Expand folders when searching in the folder widgets (Loader + Launcher).
Additional info
I'm not entirely sure whether the change implemented here is 'correct' according to the model/view separation logic we want to have in tools, but it shows the behavior artists in our studio we like more (and is logic that behaved similarly in OpenPype actually).
Without this PR when searching in the folder widget it would not expand any folders:
With this PR it defaults to auto-expanding all:
The benefit to this is that when searching you automatically can see all the results and directly can see whether you found what you're looking for or should filter more or not.
Testing notes: