-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substance Painter: Add support for sync workfile version #590
Substance Painter: Add support for sync workfile version #590
Conversation
Task linked: AY-5648 Substance work / publish version sync |
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test both occasions when Follow workfile version
been set in Core addon
as seen here
when published already present texture set
publish instance it works and publish the version
following the workfile version
.
It also works when the Core addon
settings being disabled, but the user sets it ON
when creating new Publish instance
also works fine!
Small note: there is no hint message
for this option as with others...we should also incorporate it for this settings too.
Overall works nicely in both occasions...
One small comment: @moonyuet would it be possible to keep visible that option |
I wouldn't actually make that an artist's choice - that's a studio choice usually. Can you think of a use case where an artist really wants to take that control? Actually - I also wouldn't expose it on the Create tab. Maya, Houdini and others have similar functionality but I've never seen that toggle in any of the integrations on any Creators? What am I missing? :) |
server_addon/substancepainter/client/ayon_substancepainter/plugins/create/create_textures.py
Outdated
Show resolved
Hide resolved
...on/substancepainter/client/ayon_substancepainter/plugins/publish/collect_workfile_version.py
Outdated
Show resolved
Hide resolved
..._addon/substancepainter/client/ayon_substancepainter/plugins/publish/collect_context_data.py
Outdated
Show resolved
Hide resolved
client/ayon_core/plugins/publish/collect_anatomy_instance_data.py
Outdated
Show resolved
Hide resolved
@BigRoy I get your point, makes sense @moonyuet But now we can control it only globally within I think we need to allow user to set it within @BigRoy opinion on this? |
Yes, it is
@BigRoy I think we can do this too by using |
I'd make the logic here match the other integrations - so it's aligned and once we move things over it works for all. Best not to deviate here, especially if it's "temporary". |
I already restored the creator logic and the sync workfile version can only sync through the global settings and we can integrate profile setting later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/ayon_core/plugins/publish/collect_anatomy_instance_data.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Changelog Description
This PR is to add
sync workfile version
option into substance painter host.Additional info
Build the latest version of core addon and substance painter addon
Testing notes:
ayon+settings://core/publish/CollectAnatomyInstanceData/follow_workfile_version