Chore: Create server addon package enhancements #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/S
host: Houdini
type: enhancement
MustafaJafar
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Create package script does not copy files around unless it was asked for. So if zip should be created, only file which is created on disk is output package zip.
Additional info
Do most of the logic only in memory without copying files around. This means that
--keep-sourcesargument does not have usage as there are no sources. But--skip-zipstill can be used.Changed docstring in houdini
version.py(the template changed while PR was opened).Testing notes:
python ./create_ayon_addon.pyshould output the same packages as before but a little bit faster.