Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Applications addon decouple of logic #621

Merged
merged 14 commits into from
Jun 14, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 10, 2024

Changelog Description

Moved some amount of applications logic to applications addon. Core still has to know some logic of applications addon but not all of it.

Additional info

The biggest disadvantage is that core addon has to know how to create action classes, their icons, labels if are enabled/disabled tc. which should be in charge of the applications addon. Applications addon is also providing the icons.

Selection object in launcher has support to get project settings.

Applications addon did not yet change the logic, only has it available, so old ayon core will still work, and new ayon-core can work with both new and old applications addon versions.

Because we're planning how applications addon work this is "must have" PR.

Testing notes:

  1. Applications actions show icons in launcher tool.
  2. Works with new core and new applications addon.
  3. Works with old core and new applications addon.
  4. Works with new core and old applications addon.
  5. Works with old core and old applications addon (behavior before this PR).

Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but someone else should also test it.

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work fine, not tested it in all combinations though

@iLLiCiTiT iLLiCiTiT merged commit 0490ab3 into develop Jun 14, 2024
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/applications-addon-decouple branch June 14, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants