Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Color Transcode: Fix duplicated function _rename_in_representation #629

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jun 10, 2024

Changelog Description

Fix duplicated function _rename_in_representation

Additional info

Avoids redeclaration

Testing notes:

  1. Extract Color Transcode should still work

@ynbot ynbot added the size/XS label Jun 10, 2024
@BigRoy BigRoy requested review from kalisp and iLLiCiTiT June 10, 2024 23:32
@LiborBatek
Copy link
Member

@BigRoy isnt this a duplicity with this one already created? https://github.com/ynput/ayon-core/pull/620

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 11, 2024

@BigRoy isnt this a duplicity with this one already created? https://github.com/ynput/ayon-core/pull/620

No - that fixes a different issue.

This PR solely fixes the method _rename_in_representation existing twice directly after each other in the code. It likely got 'duplicated' at some point in a merge conflict and got missed at the time.

@iLLiCiTiT iLLiCiTiT merged commit 717955e into ynput:develop Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants