Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Use origin username when running publish #630

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Chore: Use origin username when running publish #630

merged 3 commits into from
Jun 11, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Make ayon-api behave as other user during publish when current user is service user.

Additional info

This should cause that farm publishing create entities as user who sent the job.

Testing notes:

  1. Send job to publish on farm.
  2. Make sure you have filled service api key on farm.
  3. Validate in AYON WebUI that entities are created as the user who sent job.

@iLLiCiTiT iLLiCiTiT requested a review from antirotor June 11, 2024 08:51
@ynbot ynbot added size/XS type: enhancement Improvement of existing functionality or minor addition labels Jun 11, 2024
@iLLiCiTiT iLLiCiTiT requested a review from kalisp June 11, 2024 08:51
@iLLiCiTiT iLLiCiTiT mentioned this pull request Jun 11, 2024
Merged
kalisp
kalisp requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think set_default_service_username is exposed in ayon-python-api (at least not in 1.0.6)

kalisp
kalisp approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My user is correctly passed in.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Jun 11, 2024
@iLLiCiTiT iLLiCiTiT merged commit f1b8d08 into develop Jun 11, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/register-username-during-publishing branch June 11, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iLLiCiTiT @kalisp @ynbot