Fix: aftereffects review not displayed in ftrack #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin depends on review in families logic which got put there only after this plugin (because of previous move order to accommodate deadline collection data). This plugin must run after collect_review BUT before collect DL credentials!
Without it will render frame 0 which might result in black image instead of correct frame (1001).
Folder path messed up os.path.join, resulting in wrong file path pointing to c:/file_name.png. Folder path is actually not needed here, it is already included in base_dir.
|
Task linked: AY-5750 AE review not displayed in Ftrack |
ynbot
added
type: bug
m-u-r-p-h-y
added
the
sponsored
64qam
approved these changes
Jun 18, 2024
iLLiCiTiT
reviewed
Jun 18, 2024
server_addon/deadline/client/ayon_deadline/plugins/publish/submit_aftereffects_deadline.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Jun 18, 2024
server_addon/aftereffects/client/ayon_aftereffects/plugins/publish/collect_render.py
Outdated
Show resolved
Hide resolved
…fix/AY-5750_AE-review-not-displayed-in-Ftrack
iLLiCiTiT
approved these changes
Jun 18, 2024
|
BTW please bump version of AE and Deadline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Solved bug caused review not getting created.
Testing notes: