Addons: Change color types back to their previous type #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix issue with conversion of settings overrides after PR.
Additional info
The issue is that conversion between the color types cannot happen automatically and conversion of overrides for specific version of addon is not yet implemented for addons (I though it is). The biggest difference from current values is that alpha is not used or is used float instead of int, all cases are already handled in code so it is really just change of types in settings. Keeping addon versions as their current version should be what they really are.
New types in models were just commented out as preparation for moment when the conversion of overrides will be working on addons.
Testing notes: