Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: Remove unused "remote publish" workflow for Houdini #693

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jun 24, 2024

Changelog Description

Remove the "Remote Publish" workflow that lives within the ayon_houdini codebase but is unused. Some farm submissions for rendering and caching do work, with render targets allow local, farm rendering and using existing frames (for some) but none of these seem to rely on this Remote Publish logic that essentially was unused and likely would not work at all.

Additional info

This likely was once a 'straight' copy from colorbleed codebase back in the Avalon-era.

I also detected one other plug-in that seemed to have deadline as registered target for the Pyblish plug-in here (reported on discord). Which likely tells me that this plug-in is currently never triggering since we never seem to be registering that target. We only ever seem to register local, farm, remote and automated according to the codebase.

Testing notes:

  1. Houdini integration should still work
  2. Houdini publishing should still work
  • Local publishing
  • Farm render publishing
  • Farm cache publishing

This likely was once a 'straight' copy from `colorbleed` codebase back in the Avalon-era.
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Houdini.
Farm cache submission hit some issue but it is not related to this PR.

  File "D:\ayon-core\client\ayon_core\pipeline\farm\pyblish_functions.py", line 942, in create_instances_for_cache
    raise ValueError("Found multiple non related files "
ValueError: Found multiple non related files to render, don't know what to do with them.

@BigRoy BigRoy merged commit 8fafba1 into ynput:develop Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants