Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher: Remove Literal typehint #723

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Publisher: Remove Literal typehint #723

merged 1 commit into from
Jun 27, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Remove used Literal typehint.

Additional info

Typehint Literal is breaking older DCCs with Python older than 3.8.

Testing notes:

  1. Publisher works in those DCCs.

@iLLiCiTiT iLLiCiTiT requested a review from 64qam June 27, 2024 15:33
@ynbot ynbot added type: bug Something isn't working size/XS labels Jun 27, 2024
@iLLiCiTiT iLLiCiTiT mentioned this pull request Jun 27, 2024
Merged
BigRoy
BigRoy approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense :) the fun of supporting many versions, yay!

@iLLiCiTiT iLLiCiTiT merged commit 1d4986e into develop Jun 27, 2024
11 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/remove-literal-typehint branch June 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@64qam 64qam 64qam approved these changes

Assignees

@64qam 64qam

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iLLiCiTiT @BigRoy @64qam @ynbot