Fix: dirmap wasn't using local site values #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has wrong arguments, it would require SiteSync addon. Used only in dirmap file, where it could be replaced directly by SiteSync addon's method.
Addon's get_site_root_overrides should return overridden root values for any site which is overridden by Site Settings. 'studio' site is currently overridden by `Roots` tab and comes from project settings directly.
|
Task linked: OP-8272 Dirmap does not work with sitesync |
LiborBatek
approved these changes
Jul 2, 2024
iLLiCiTiT
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Some DCC(Maya, Nuke) offer dirmap functionality, eg. remapping file paths from source to destination. If dirmap is enabled and artist is using local site, it should use as a source root value from
Site Settings(which might be different for each artist) rather than static mapping fromayon+settings://nuke/dirmap?project=ayon_testfor example.Testing notes:
ayon+settings://nuke/dirmap?project=ayon_testLocal Settingsshould be usedwhere values in
active roots overridesshould match what artist has inSite Settings