Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Houdini Mantra IFD local submission #75

Closed
wants to merge 9 commits into from

Conversation

MustafaJafar
Copy link
Contributor

Changelog Description

Mantra IFD extractor local submission was failing because its extractor didn't include render_rop

Testing notes:

  1. publish mantra ifd local and on farm. it should work.

@MustafaJafar
Copy link
Contributor Author

I have a question:
I'm not sure about the workflow of using published ifds ?
Also, how ifds are related to these temp paths ? e.g. what would happen if I deleted them after publishing the ifds ?
image

@moonyuet
Copy link
Member

I have a question: I'm not sure about the workflow of using published ifds ? Also, how ifds are related to these temp paths ? e.g. what would happen if I deleted them after publishing the ifds ? image

This is just providing the temporary storage for ifd file if there is any.

We need to double check the integrate.py and resourced_file.py to see if the related family of this extractor is included. It seems that it doesn''t get published correctly and it doesn't show up in the loader.

@MustafaJafar
Copy link
Contributor Author

Note:
As far as I know the published IFD files will keep the link to the original generated temp data in the workfiles which can error if the temp data are deleted.

Thus, I've enabled Save Geometry Inline
As I have no idea to publish the generated temp data along with the IFD files while updating the link between them.

image

@moonyuet
Copy link
Member

moonyuet commented Feb 19, 2024

Note: As far as I know the published IFD files will keep the link to the original generated temp data in the workfiles which can error if the temp data are deleted.

Thus, I've enabled Save Geometry Inline As I have no idea to publish the generated temp data along with the IFD files while updating the link between them.

image

maybe we can just add an optional validator to check for the temp to avoid the error with the temp file storage.
EDIT: I mean the validator to check on whether Save Geometry Incline button being turned on.

@moonyuet
Copy link
Member

I tested with houdini, all functions work.
I think it may be good idea to add optional validator to check on the Save Geometry Incline button being turned on, but it can be in different PRs(if anyone needs that)

@MustafaJafar MustafaJafar requested a review from BigRoy April 2, 2024 10:39
# Enable `Save Geometery Inline`
# As it's hard to update the geo reference
# inside the IFD file after publishing the IFDs.
"vm_inlinestorage": 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containing all the geometry into the output file means you're basically bloating the filepath a lot. I really feel like this is the opposite of what a 'render' file should look like - it should be a lightweight file whenever possible.

I understand the comment as to what is hard about changing paths in the output files - but I'm wondering, why would we need changing anyway? Is it because of mixed farms, etc?

Also, if this is a "local" submission - do we even need the IFD file? Or what's this about?

Aren't IFD's intermediate files just used for rendering? They don't need publishing - they are not proxies. They are just files used for the current render. If it's a local render - then technically it can almost live in memory or transparently be in a temp folder on the local machine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we need changing anyway? Is it because of mixed farms, etc?

As far as I know it's not only about mixed farms but also about having the IFD files with the correct data.
and keeping that link may produce IFD files that points to a wrong/non-existing geometry files.

Also, I doubt this problem is going to occur also with farm IFD publishing.

Aren't IFD's intermediate files just used for rendering? They don't need publishing - they are not proxies. They are just files used for the current render.

I'm not sure about the why we have IFD family I can obly remember it was added by @moonyuet in ynput/OpenPype#4903
Could @moonyuet you shed some light ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containing all the geometry into the output file means you're basically bloating the filepath a lot. I really feel like this is the opposite of what a 'render' file should look like - it should be a lightweight file whenever possible.

I understand the comment as to what is hard about changing paths in the output files - but I'm wondering, why would we need changing anyway? Is it because of mixed farms, etc?

Also, if this is a "local" submission - do we even need the IFD file? Or what's this about?

Aren't IFD's intermediate files just used for rendering? They don't need publishing - they are not proxies. They are just files used for the current render. If it's a local render - then technically it can almost live in memory or transparently be in a temp folder on the local machine?

We can just remove the entire product type instead. i mean same thing has been raised by @fabiaserra before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I don't see a point to keep IFDs around, as opposed to ASS files which have more benefits as you can use them as an exchange format across the different Arnold plugins

@fabiaserra
Copy link
Contributor

has there been any progress or plans on separating the extraction/render of nodes from the publish?

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 2, 2024

has there been any progress or plans on separating the extraction/render of nodes from the publish?

As far as I know, there hasn't no. Might be one for Dee Coureau (I dont know his Github handle).

@fabiaserra
Copy link
Contributor

has there been any progress or plans on separating the extraction/render of nodes from the publish?

As far as I know, there hasn't no. Might be one for Dee Coureau (I dont know his Github handle).

I'm waiting for the 0.3.0 breaking release (this week?) to update my fork and migrate to ayon-core and test any new features before I start being loud in the DCC fronts again, right now I'm busy making the Shotgrid sync stable

@MustafaJafar
Copy link
Contributor Author

has there been any progress or plans on separating the extraction/render of nodes from the publish?

As far as I know, there hasn't no. Might be one for Dee Coureau (I dont know his Github handle).

it's @dee-ynput

@MustafaJafar MustafaJafar marked this pull request as draft April 3, 2024 15:48
@MustafaJafar
Copy link
Contributor Author

Marking this PR as a draft in favor of this comment #75 (comment)
waiting till making a decision whether to remove the IFD product type or not.

@antirotor
Copy link
Member

antirotor commented Apr 9, 2024

I don't think that we want to publish IFDs at all. Let's remove it in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants