Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Resolve documentation (user+admin) for recent publisher work. #289

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Adjust Resolve documentation (user+admin) for recent publisher work. #289

merged 6 commits into from
Oct 16, 2024

Conversation

robin-ynput
Copy link
Contributor

Changelog Description

As suggested on Discord, adjust Resolve documentation to reflect recent work:

  • Ensure Python and OpenTimelineIO information is up to date
  • Change instruction link from openpype to ayon_resolve for Python 3.6
  • Rephrase and adjust visuals based on new publisher from ayon-resolve-0.3.0

Testing notes:

  1. Validated through a local docusaurus build

@robin-ynput robin-ynput self-assigned this Oct 15, 2024
@robin-ynput robin-ynput added addon: Resolve documentation Improvements or additions to documentation Artist Docs Admin Docs type: enhancement New feature or request labels Oct 15, 2024
robin-ynput
robin-ynput commented Oct 15, 2024
View reviewed changes
website/yarn.lock Outdated Show resolved Hide resolved
BigRoy
BigRoy approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small tiny notes - otherwise looks good to me.

And another question:
What does the 'in complience with AYON' mean? Is the launcher supposed to be built with 3.10 already? (it's 3.9 still for me). If AYON desktop tools are still 3.9 currently - what makes it 'comply with AYON'?

website/docs/addon_resolve_artist.md Outdated Show resolved Hide resolved
website/docs/addon_resolve_artist.md Outdated Show resolved Hide resolved
website/yarn.lock Outdated Show resolved Hide resolved
@robin-ynput @MustafaJafar @BigRoy
Apply suggestions from code review
ffd3038 
Co-authored-by: Mustafa Jafar <mustafataherzaky@outlook.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@robin-ynput
Copy link
Contributor Author

Some small tiny notes - otherwise looks good to me.

And another question: What does the 'in complience with AYON' mean? Is the launcher supposed to be built with 3.10 already? (it's 3.9 still for me). If AYON desktop tools are still 3.9 currently - what makes it 'comply with AYON'?

I understood it as an Python 3.10 that is working with AYON librairies
but I'll rephrase it to avoid any confusion.

MustafaJafar
MustafaJafar approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good.

@robin-ynput robin-ynput merged commit 26c0ea3 into main Oct 16, 2024
@robin-ynput robin-ynput deleted the enhancement/update_resolve_doc branch October 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy approved these changes

@MustafaJafar MustafaJafar MustafaJafar approved these changes

Assignees

@robin-ynput robin-ynput

Labels
addon: Resolve Admin Docs Artist Docs documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robin-ynput @BigRoy @MustafaJafar