Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load LOPs: Support update via context options (replace parm callbacks with expressions) #112

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Oct 3, 2024

Changelog Description

Replace the Load LOPs parm callbacks with expressions on the file parms to support Solaris Context Options.

Additional info

With this PR, the LOP load nodes now LIVE update based on context options. Meaning, using context-options you can now easily do multi-shot lighting!

Fixes: #111

2024-10-04.10-13-12.mov

Credit: Audio snippet in the background at the beginning is a few seconds of the start from this Youtube video

TODO

  • Fix the 'warning message' remaining on the node on path update because it doesn't trigger that callback anymore
  • Fix the thumbnails (when enabled) not updating on representation changes.

Testing notes:

  1. Load Asset LOP should work consistently
  2. Load Shot LOP should work consistently
  3. Both should NOT be super slow
  4. When using Solaris Context Options the loader should update along live.
    • even with Edit Context Options LOP updates should be live

…ms to support Solaris Context Options (Draft)
@BigRoy BigRoy added the type: feature Adding something new and exciting to the product label Oct 3, 2024
@BigRoy BigRoy self-assigned this Oct 3, 2024
@BigRoy BigRoy linked an issue Oct 4, 2024 that may be closed by this pull request
2 tasks
@BigRoy BigRoy marked this pull request as ready for review October 4, 2024 08:00
@BigRoy BigRoy mentioned this pull request Oct 14, 2024
9 tasks
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool and it's live!
Animation_7
Animation_8

Should we care about these warnings ?
image

Also, should we have default context options and probably manage them on AYON context change?

@BigRoy
Copy link
Contributor Author

BigRoy commented Oct 17, 2024

Should we care about these warnings ?

Yes, we should! I thought I had fixed that already but maybe I forgot to push. Will continue with this.

Will also need to decide what to do with the thumbnails. Before this PR it was created to "auto-update" on context update (but especially now with those being expressions that makes even less sense.) Mark from SideFX says it best:

You should really not be "doing things" as a result of evaluating expressions.

So I guess for now the easiest way is to remove how it's "live" and then just add a "Update thumbnail" button. We can think of better fixes down the line.

@MustafaJafar
Copy link
Contributor

Isn't this cool!
I published three products pointcacherock_1, pointcacherock_2 and pointcacherock_3
and loading them inside a loop works! (as loops are based on context options)

Note: I don't know if my example here is favorite in production. tbh, I don't know what is the best way to publish multiple variants of my pointcache products. maybe it's the correct workflow since different variants of an AYON product are just different AYON products.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Adding something new and exciting to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LOPs loaders upon context options changing (to allow multi-shot workflows)
2 participants