Render layer name collector

[antirotor]

Changelog Description

This PR adds collector for render layer names - so they can be used later on in anatomy templates (either for publishing or delivery).

Warning

Due to the dynamic nature of product templates it is difficult to determine good group_name from that. It should be basically product_name without aov data in it, but since the product name template might look like {product[type]}<{Renderlayer}><_{Aov}>, it is difficult to get it just from the resolved string.

Additional info

Note

To make use of the collected data, you need ynput/ayon-core#841. This is continuation of ynput/ayon-core#447

Testing notes:

1. With mentioned ayon-core PR enable new behavior in the settings
2. Set render product name template correctly
3. Render something (locally and on farm)

[moonyuet]

Did a simple test with both local and farm rendering mantra. It is rendered successfully.

I will test it with different template later to double confirm

[MustafaJafar]

I need to say, that adding a wrong/bad value for templates name profiles can lead to this error.

and, they may be clueless until they open the details page.
for reference, Here's my render profile template {product[type]}<_{Renderlayer}>

So, could we do something to help about it ?
maybe CollectLocalRenderInstances message about creating instances with the same name.

[moonyuet]

I need to say, that adding a wrong/bad value for templates name profiles can lead to this error.

This product name template is not applicable for the houdini host only, guess we should check if there is wrong template name generally.

So, could we do something to help about it ? maybe CollectLocalRenderInstances message about creating instances with the same name.

From your screenshot, it seems there is something wrong when creating render instances with specific name which these variants name doesn't get check which leads to the duplicates. It is supposed that it is always checking(it works at least when we create rop instance with the same names.

[antirotor]

I've added some help in ynput/ayon-core@f752940

With product name templates (not just connected to these PRs), they need to be configured really carefuly. Any mistake can break a lot of things so it shouldn't be something artists themselves hit that often.

[MustafaJafar]

Firstly, I must have a template profile for render in Houdini, otherwise the publisher will complain about having multiple instances with the same name.

---

Farm doesn't use the correct naming but it works locally.

Local Log:

From Farm job json file:

{
    .
    .
    "instances": [
        {
            "aov": "beauty",
            "productGroup": "renderCfxMantra_ropTest",
            "productName": "renderCfxMantra_ropTest_beauty",
            "productType": "render",
            "renderlayer": "mantra_ropTest",
            .
            .
        },
        {
            "aov": "N",
            "productGroup": "renderCfxMantra_ropTest",
            "productName": "renderCfxMantra_ropTest_N",
            "productType": "render",
            "renderlayer": "mantra_ropTest",
            .
            .
        },
        {
            "aov": "P",
            "productGroup": "renderCfxMantra_ropTest",
            "productName": "renderCfxMantra_ropTest_P",
            "productType": "render",
            "renderlayer": "mantra_ropTest",
            .
            .
        }
    ],
    .
    .
}

[MustafaJafar]

Hey, this works fine on my side.
My local render and farm render are following my render product template {product[type]}<_{Renderlayer}><_{Aov}>

For information this toggle works only for farm.
Should we port its logic to CollectLocalRenderInstances?

• ayon+settings://core/tools/creator/use_legacy_product_names_for_renders
  

[antirotor]

For information this toggle works only for farm. Should we port its logic to CollectLocalRenderInstances?

ah, we definitely should...

[MustafaJafar]

This now is working in local and farm.
Both respect use_legacy_product_names_for_renders logic.

[antirotor]

Tested and it works indeed, thanks.