Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: local render remove redundant keys and add missing keys #93

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Sep 7, 2024

Changelog Description

resolve #92
it also removes redundant keys frameStart and frameEnd and adds missing key publish_attributes.

Additional info

This PR just picks few commits from a community PR #77
where community PR tried to fix other problems at the same time that deviated from the problem the PR was trying to fix originally.

Testing notes:

  1. create a camera with animated focal length
  2. publish local render (with review toggle on)

@MustafaJafar MustafaJafar added type: bug Something isn't working community Issues and PRs coming from the community members labels Sep 7, 2024
@MustafaJafar MustafaJafar self-assigned this Sep 7, 2024
@MustafaJafar
Copy link
Contributor Author

MustafaJafar commented Sep 7, 2024

Here's a test run
image

the resultant review.. which includes the variable focal length.

robo_roboangry_render_beauty_v032_h264.mp4

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a simple test in my side, Looks good.

@moonyuet moonyuet self-requested a review September 10, 2024 09:03
@MustafaJafar MustafaJafar changed the title Bugfix/local render add frameStartHandle and frameEndHandle Bugfix: local render remove redundant keys and add missing keys Sep 10, 2024
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@BigRoy BigRoy merged commit df6fa8d into develop Sep 10, 2024
1 check passed
@MustafaJafar MustafaJafar mentioned this pull request Sep 10, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local render missing frame start end handle keys
4 participants