Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support underscore delimiter for yeti UDIM textures #129

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 30, 2024

Changelog Description

Correctly collect sequences with _1001.exr instead of only delimited by . like .1001.exr.

Additional info

Fixes #117

This same function is also used for collecting Ornatrix textures - so it may be worth running a check of publishing ornatrix textures along as well.

Testing notes:

  1. Load a texture file in Yeti with _ delimiter, like: C:/projects/ayontest/asset/char_hero/publish/image/textureMain.Diffuse/v002/ynts_char_hero_textureMain.Diffuse_v002_<UDIM>.png

image
image

@BigRoy BigRoy added the type: bug Something isn't working label Sep 30, 2024
@BigRoy BigRoy self-assigned this Sep 30, 2024
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.
Tested with ornatrix rig. The changes does not affect the publish.
image

@LiborBatek can you do the test on Yeti?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work for me (did try 2 times and also built the ayon-maya addon for the second try) gives validation errors (enclosing the JSON file too)

Screenshot 2024-10-02 111039

Screenshot 2024-10-02 112603

And the full JSON log:

publish-report-241002-11-25.json.txt

@BigRoy
Copy link
Contributor Author

BigRoy commented Oct 2, 2024

Thanks @LiborBatek can you show me the udim files on disk?

@BigRoy
Copy link
Contributor Author

BigRoy commented Oct 2, 2024

Actually - I think I've found it. For whatever reason my filename tested did have more than one dot in the filename so it passed another check. I think I may have fixed your case with b882f60

Any chance it's easy for you to try again?

@BigRoy BigRoy requested a review from LiborBatek October 2, 2024 10:44
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now!

I have also checked the published yetiRig via loading it and inspect the asset,

All good!

image

@BigRoy BigRoy merged commit d92fddf into ynput:develop Oct 2, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/AY-6769_yeti_udim_underscore_delimiter branch October 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-6769_Yeti UDIM underscore delimiter
3 participants