Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings for deprecated validator ValidateModelName #140

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

antirotor
Copy link
Member

Changelog Description

ValidateModelName was removed from Maya addon because it was obsolete and using some OpenPype specific logic here ynput/ayon-core#93 but Settings were left. This PR is removing also the settings.

@antirotor antirotor added the type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.)) label Oct 7, 2024
@antirotor antirotor self-assigned this Oct 7, 2024
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of the missing section as pointed out here this looks good to me.

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for me and I agree @BigRoy to define the section for the model-related validators. Simple test in maya,
image

@BigRoy BigRoy merged commit abf707f into develop Oct 8, 2024
1 check passed
@BigRoy BigRoy deleted the chore/remove-ValidateModelName-settings branch October 8, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Changes to the code that don't affect product functionality (Technical debt, refactors etc.))
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants