Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Substance Painter 10.1 (workaround new substance painter API bug) #15

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Support Substance Painter 10.1 (workaround new substance painter API bug) #15

merged 5 commits into from
Sep 23, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 22, 2024

Changelog Description

Adds support for Substance Painter 10.1 by working around a bug in their API.

Additional info

Fixes #13

Testing notes:

  1. Install Substance Painter 10.1
  2. Publishing should work as intended.

@BigRoy BigRoy added the type: bug Something isn't working label Sep 22, 2024
@BigRoy BigRoy self-assigned this Sep 22, 2024
This was referenced Sep 22, 2024
Closed
Closed
moonyuet
moonyuet reviewed Sep 22, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the replace() doesn't help with the command. I commented for the suggested change. (It's just the version info and some command issue although the command looks right with the replace())
image
After the suggested change of the comment
image

BigRoy and others added 2 commits September 23, 2024 12:18
@BigRoy @moonyuet
Update client/ayon_substancepainter/api/lib.py
5d40872 
Co-authored-by: Kayla Man <64118225+moonyuet@users.noreply.github.com>
@BigRoy
Cosmetics
ef1c502
@moonyuet moonyuet self-requested a review September 23, 2024 10:38
moonyuet
moonyuet approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.
image

@moonyuet moonyuet merged commit 637e896 into develop Sep 23, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/substance_10.1_support branch September 23, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonyuet moonyuet moonyuet approved these changes

Assignees

@BigRoy BigRoy

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect Texture Set Error out in Substance Painter 10.1
2 participants
@BigRoy @moonyuet