Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

convert premiere to pype2 #19

Merged
merged 12 commits into from
May 4, 2020
Merged

convert premiere to pype2 #19

merged 12 commits into from
May 4, 2020

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Apr 17, 2020 •
edited
Loading

dependency:
ynput/OpenPype#100

@jakubjezek001 jakubjezek001 self-assigned this Apr 17, 2020
@jakubjezek001 jakubjezek001 added the enhancement New feature or request label Apr 17, 2020
@jakubjezek001 jakubjezek001 mentioned this pull request Apr 17, 2020
Closed
@jakubjezek001 jakubjezek001 changed the title [draft] convert premiere to pype2 convert premiere to pype2 Apr 23, 2020
@jakubjezek001 jakubjezek001 mentioned this pull request Apr 23, 2020
Merged
@iLLiCiTiT
Copy link
Member

Please remove ~/pype-config/presets/services/adobe_communicator.json preset is not used in code.

@jakubjezek001
Copy link
Member Author

Please remove ~/pype-config/presets/services/adobe_communicator.json preset is not used in code.

well I don't mind to remove it but is it wise to have it hard-coded in pype\services\adobe_communicator\adobe_comunicator.py rather then delegated by presets?

@iLLiCiTiT
Copy link
Member

is it wise to have it hard-coded in

Yes. It is not wise to set it in presets. If anybody change just one value in this preset then whole adobe communiator won't work.
There is nothing which may or can change per client configuration...

@mkolar mkolar merged commit 86d5a7b into develop May 4, 2020
@mkolar mkolar deleted the feature/PYPE-624-convert-premiere-to-pype2 branch May 25, 2020 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antirotor antirotor Awaiting requested review from antirotor

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@jakubjezek001 jakubjezek001

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubjezek001 @iLLiCiTiT @mkolar