Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Anatomy fill custom root #84

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 14, 2021

Issue

1.) Anatomy does not allow to fill different roots than has defined in roots.json, which is rule by design of anatomy, but it may be helpfull to fill rootless path with custom root.
2.) Another issue is that find_root_template_from_path does not check if root value is filled with nonempty string so may return invalid values.

Changes

1.) Implemented fill_root_with_path class method which fill root key in rootless path with entered directory path, no matter if is single or multiroot. Single and multiroot is only reason why this helper method is required.
2.) find_root_template_from_path check root values if are empty.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@mkolar mkolar changed the base branch from master to release/2.14.6 January 15, 2021 12:10
@mkolar mkolar merged commit dc5fe7e into release/2.14.6 Jan 15, 2021
@mkolar mkolar added the enhancement New feature or request label Jan 22, 2021
@mkolar mkolar deleted the hotfix/anatomy_fill_custom_root branch January 26, 2021 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants