This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
1.) Anatomy does not allow to fill different roots than has defined in
roots.json
, which is rule by design of anatomy, but it may be helpfull to fill rootless path with custom root.2.) Another issue is that
find_root_template_from_path
does not check if root value is filled with nonempty string so may return invalid values.Changes
1.) Implemented
fill_root_with_path
class method which fill root key in rootless path with entered directory path, no matter if is single or multiroot. Single and multiroot is only reason why this helper method is required.2.)
find_root_template_from_path
check root values if are empty.