Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full screen toggle functionality #189

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Add full screen toggle functionality #189

merged 3 commits into from
Dec 8, 2023

Conversation

ynshung
Copy link
Owner

@ynshung ynshung commented Dec 4, 2023

Make the shorts full screen by keybind 'F' and the #page-manager will be full-screened. The reason #shorts-container is not full-screened is that the navigation container at the right (go up and down) will not be visible and it doesn't make the video itself bigger than it is.

Credit to #171, closes #187

Future implementation: button on shorts itself

@ynshung
Copy link
Owner Author

ynshung commented Dec 4, 2023

@adsuth I'm facing the issue where for user with the previous version, when there is a new keybind the 'Key' is completely blank (example image) and the user need to reassign the key:

image

How do you think we should assign the new key when new versions rolled out?

I also faced another issue for the first time which I couldn't assign it to the 'F' key as it says it's in use, I'm not able to reproduce it again so it probably just a small issue

@adsuth
Copy link
Collaborator

adsuth commented Dec 4, 2023

Not sure i thought that itd default to "<disabled>" if it was unpopulated? Maybe do a cursory check if the value is empty, make it disabled?

Busy with uni so i cant give it much time atm unfortunately

edit: it read that as a tag sorry

@ynshung
Copy link
Owner Author

ynshung commented Dec 4, 2023

Not sure i thought that itd default to "" if it was unpopulated? Maybe do a cursory check if the value is empty, make it disabled?

Busy with uni so i cant give it much time atm unfortunately

Alright thanks for the comment, I'll take a look again when I'm free

Edit: My testing seems to be working now, weird

@ynshung ynshung merged commit c29f2c4 into master Dec 8, 2023
3 checks passed
@ynshung ynshung deleted the full-screen branch December 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen option w/button
2 participants